fix(gallery): persist inference defaults under parameters - #11256
Open
localai-org-maint-bot wants to merge 1 commit into
Open
fix(gallery): persist inference defaults under parameters#11256localai-org-maint-bot wants to merge 1 commit into
localai-org-maint-bot wants to merge 1 commit into
Conversation
Gallery installs merged family defaults at the YAML root and only re-marshaled them on the artifact path. Persist the defaults in the loader-visible parameters map for every install path while preserving authored overrides. Assisted-by: Codex:gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Persist model-family inference defaults in the nested
parametersmap thatModelConfigreads, and re-marshal the merged config before either the artifact orfiles:install path continues. Existing authored parameter values remain authoritative.Adds regression coverage for both artifact-binding and explicit-file installs.
Closes #11230
Testing
go test ./core/gallery -run TestGallery -ginkgo.focus="gallery inference defaults|installs a previously broken index entry" -count=1go test ./core/gallery -run TestGallery -ginkgo.skip="should return error when backend is not found|should install backend from gallery|parses github with a branch" -count=1go vet ./core/gallerygit diff --check HEAD^ HEADThe three skipped specs depend on GitHub/Gist HTTP fixtures that return HTTP 403 in this cron environment. A full-suite attempt reproduced those unrelated fixture failures.
Checklist